root/ludu-cloud
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

商品、订单相关代码的 Review

Browse Source
This commit is contained in:
YunaiV 2020-05-13 19:06:19 +08:00
parent 03857426aa
commit 4580f61489
4 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
order/order-biz/src/main/java/cn/iocoder/mall/order/biz/dto/order/OrderCreateDTO.java
View File

@ -16,6 +16,7 @@ import java.util.List;
*/ */
@Data @Data
@Accessors(chain = true) @Accessors(chain = true)
// TODO FROM 芋艿 to xiaofeng：辛苦后续补充下 Validation 注解哈
public class OrderCreateDTO implements Serializable { public class OrderCreateDTO implements Serializable {
/** /**

6
order/order-rest/src/main/java/cn/iocoder/mall/order/rest/request/admin/OrderPageRequest.java
View File

@ -3,11 +3,12 @@ package cn.iocoder.mall.order.rest.request.admin;
import cn.iocoder.mall.order.biz.bo.order.OrderBO; import cn.iocoder.mall.order.biz.bo.order.OrderBO;
import io.swagger.annotations.ApiModel; import io.swagger.annotations.ApiModel;
import io.swagger.annotations.ApiModelProperty; import io.swagger.annotations.ApiModelProperty;
import java.io.Serializable;
import java.util.List;
import lombok.Data; import lombok.Data;
import lombok.experimental.Accessors; import lombok.experimental.Accessors;
import java.io.Serializable;
import java.util.List;
/** /**
* 订单分页 vo * 订单分页 vo
* *
@ -17,6 +18,7 @@ import lombok.experimental.Accessors;
@Data @Data
@Accessors(chain = true) @Accessors(chain = true)
@ApiModel("订单VO") @ApiModel("订单VO")
// TODO FROM 芋艿 to jwf1173：命名要改下，rest 以 Admins 和 Users 开头
public class OrderPageRequest implements Serializable { public class OrderPageRequest implements Serializable {
/** /**

2
system/system-biz/src/main/java/cn/iocoder/mall/system/biz/dao/user/UserMapper.java
View File

@ -2,7 +2,6 @@ package cn.iocoder.mall.system.biz.dao.user;
import cn.iocoder.mall.system.biz.dataobject.user.UserDO; import cn.iocoder.mall.system.biz.dataobject.user.UserDO;
import cn.iocoder.mall.system.biz.dto.user.UserPageDTO; import cn.iocoder.mall.system.biz.dto.user.UserPageDTO;
import cn.iocoder.mall.system.biz.dto.user.UserUpdateDTO;
import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper; import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
import com.baomidou.mybatisplus.core.mapper.BaseMapper; import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage; import com.baomidou.mybatisplus.core.metadata.IPage;
@ -26,6 +25,7 @@ public interface UserMapper extends BaseMapper<UserDO> {
* @return * @return
*/ */
default IPage<UserDO> selectUserPage(UserPageDTO userPageDTO) { default IPage<UserDO> selectUserPage(UserPageDTO userPageDTO) {
// TODO FROM 芋艿 to jwf1173：看下 QueryWrapperX 噢，已经提供判空啦
return this.selectPage(new Page<>(userPageDTO.getPageNo(), userPageDTO.getPageSize()), return this.selectPage(new Page<>(userPageDTO.getPageNo(), userPageDTO.getPageSize()),
Wrappers.<UserDO>query().lambda() Wrappers.<UserDO>query().lambda()
.eq(StringUtils.isNotBlank(userPageDTO.getNickname()), UserDO::getNickname, userPageDTO.getNickname()) .eq(StringUtils.isNotBlank(userPageDTO.getNickname()), UserDO::getNickname, userPageDTO.getNickname())

6
system/system-biz/src/main/java/cn/iocoder/mall/system/biz/dataobject/authorization/RoleDO.java
View File

@ -1,6 +1,8 @@
package cn.iocoder.mall.system.biz.dataobject.authorization; package cn.iocoder.mall.system.biz.dataobject.authorization;
import cn.iocoder.mall.mybatis.dataobject.DeletableDO; import cn.iocoder.mall.mybatis.dataobject.DeletableDO;
import cn.iocoder.mall.system.biz.enums.authorization.RoleCodeEnum;
import cn.iocoder.mall.system.biz.enums.authorization.RoleTypeEnum;
import com.baomidou.mybatisplus.annotation.TableName; import com.baomidou.mybatisplus.annotation.TableName;
import lombok.Data; import lombok.Data;
import lombok.EqualsAndHashCode; import lombok.EqualsAndHashCode;
@ -25,10 +27,14 @@ public class RoleDO extends DeletableDO {
private String name; private String name;
/** /**
* 角色编码 * 角色编码
*
* 关联 {@link RoleCodeEnum}
*/ */
private String code; private String code;
/** /**
* 角色类型 * 角色类型
*
* 关联 {@link RoleTypeEnum}
*/ */
private Integer type; private Integer type;