From e5d6a9dae1caa66053f1a98fb0373bccf4fe98e8 Mon Sep 17 00:00:00 2001
From: YunaiV <zhijiantianya@gmail.com>
Date: Tue, 24 Oct 2023 20:07:48 +0800
Subject: [PATCH] =?UTF-8?q?code=20review=EF=BC=9Abanner=20=E9=80=BB?=
 =?UTF-8?q?=E8=BE=91?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/utils/dict.ts                             |  2 +-
 .../product/spu/form/OtherSettingsForm.vue    | 41 ++-----------------
 .../mall/promotion/banner/BannerForm.vue      |  2 +-
 src/views/mall/promotion/banner/index.vue     |  2 +-
 4 files changed, 6 insertions(+), 41 deletions(-)

diff --git a/src/utils/dict.ts b/src/utils/dict.ts
index 7534fb49..489d8e4b 100644
--- a/src/utils/dict.ts
+++ b/src/utils/dict.ts
@@ -184,7 +184,7 @@ export enum DICT_TYPE {
   PROMOTION_CONDITION_TYPE = 'promotion_condition_type', // 营销的条件类型枚举
   PROMOTION_BARGAIN_RECORD_STATUS = 'promotion_bargain_record_status', // 砍价记录的状态
   PROMOTION_COMBINATION_RECORD_STATUS = 'promotion_combination_record_status', // 拼团记录的状态
-  BANNER_POSITION = 'banner_position', // banner 定位
+  PROMOTION_BANNER_POSITION = 'promotion_banner_position', // banner 定位
 
   // ========== CRM - 客户管理模块 ==========
   CRM_RECEIVABLE_CHECK_STATUS = 'crm_receivable_check_status',
diff --git a/src/views/mall/product/spu/form/OtherSettingsForm.vue b/src/views/mall/product/spu/form/OtherSettingsForm.vue
index d574ae78..d3bdb6a1 100644
--- a/src/views/mall/product/spu/form/OtherSettingsForm.vue
+++ b/src/views/mall/product/spu/form/OtherSettingsForm.vue
@@ -109,59 +109,24 @@ const props = defineProps({
 const promotionTypes = ref<DictDataType[]>([
   {
     dictType: 'promotionTypes',
-    label: '秒杀活动',
+    label: '秒杀',
     value: 1,
     colorType: 'warning',
     cssClass: ''
   },
   {
     dictType: 'promotionTypes',
-    label: '砍价活动',
+    label: '砍价',
     value: 2,
     colorType: 'warning',
     cssClass: ''
   },
   {
     dictType: 'promotionTypes',
-    label: '拼团活动',
+    label: '拼团',
     value: 3,
     colorType: 'warning',
     cssClass: ''
-  },
-  {
-    dictType: 'promotionTypes',
-    label: '限时折扣',
-    value: 4,
-    colorType: 'warning',
-    cssClass: ''
-  },
-  {
-    dictType: 'promotionTypes',
-    label: '满减送',
-    value: 5,
-    colorType: 'warning',
-    cssClass: ''
-  },
-  {
-    dictType: 'promotionTypes',
-    label: '会员折扣',
-    value: 6,
-    colorType: 'warning',
-    cssClass: ''
-  },
-  {
-    dictType: 'promotionTypes',
-    label: '优惠劵',
-    value: 7,
-    colorType: 'warning',
-    cssClass: ''
-  },
-  {
-    dictType: 'promotionTypes',
-    label: '积分',
-    value: 8,
-    colorType: 'warning',
-    cssClass: ''
   }
 ])
 
diff --git a/src/views/mall/promotion/banner/BannerForm.vue b/src/views/mall/promotion/banner/BannerForm.vue
index d794d2bf..687f26a8 100644
--- a/src/views/mall/promotion/banner/BannerForm.vue
+++ b/src/views/mall/promotion/banner/BannerForm.vue
@@ -45,7 +45,7 @@
           <el-form-item label="定位" prop="position">
             <el-radio-group v-model="formData.position">
               <el-radio
-                v-for="dict in getIntDictOptions(DICT_TYPE.BANNER_POSITION)"
+                v-for="dict in getIntDictOptions(DICT_TYPE.PROMOTION_BANNER_POSITION)"
                 :key="dict.value"
                 :label="dict.value"
               >
diff --git a/src/views/mall/promotion/banner/index.vue b/src/views/mall/promotion/banner/index.vue
index bcf6d80d..45015574 100644
--- a/src/views/mall/promotion/banner/index.vue
+++ b/src/views/mall/promotion/banner/index.vue
@@ -76,7 +76,7 @@
       </el-table-column>
       <el-table-column align="center" label="定位" prop="position">
         <template #default="scope">
-          <dict-tag :type="DICT_TYPE.BANNER_POSITION" :value="scope.row.position" />
+          <dict-tag :type="DICT_TYPE.PROMOTION_BANNER_POSITION" :value="scope.row.position" />
         </template>
       </el-table-column>
       <el-table-column align="center" label="跳转地址" prop="url" />